Open
Conversation
Contributor
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1517
Fixes CAP-602
Greptile Summary
Fixed theme toggle by adding
document.body.className = newThemein thesetThemeHandlerfunction. Previously, the theme state and cookie were updated but the DOM wasn't modified immediately, causing the UI to remain in the current theme until page reload.Confidence Score: 5/5
Important Files Changed
document.body.classNameassignment to immediately apply theme changes when toggledSequence Diagram
sequenceDiagram participant User participant ThemeToggle as Theme Toggle UI participant setThemeHandler participant State as React State participant Cookie as Browser Cookie participant DOM as document.body User->>ThemeToggle: Click theme toggle ThemeToggle->>setThemeHandler: setThemeHandler(newTheme) setThemeHandler->>State: setTheme(newTheme) setThemeHandler->>DOM: document.body.className = newTheme Note over DOM: Theme applied immediately setThemeHandler->>Cookie: Cookies.set("theme", newTheme) State-->>ThemeToggle: Re-render with new theme ThemeToggle-->>User: UI updates with new theme